commit | d28e2536ab6b8ee546a24d0041377b0a05705c7c | [log] [tgz] |
---|---|---|
author | Giovanni Ortuño Urquidi <ortuno@chromium.org> | Thu Nov 29 03:58:13 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 29 03:58:13 2018 |
tree | 5c56f20939bff0d20d2b19f5f690acd25c9061fd | |
parent | 38d840aef1ae2358ee36636b2595f88ce82c45b7 [diff] |
Revert "Use the SequenceManager in ScopedTaskEnvironment" This reverts commit 514c49d40b386bd0fc3e544257ef2ec13e458028. Reason for revert: Breaks test on Mac10.12 Tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17139 [ RUN ] WebMediaPlayerMSTest.RotationChange/3 ../../content/renderer/media/stream/webmediaplayer_ms_unittest.cc:1136: Failure Expected equality of these values: kStandardHeight Which is: 240 natural_size.height Which is: 320 Stack trace: 0 content_unittests 0x00000001030aac4b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 content_unittests 0x00000001030aa609 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 content_unittests 0x0000000102314244 content::WebMediaPlayerMSTest_RotationChange_Test::TestBody() + 3492 Original change's description: > Use the SequenceManager in ScopedTaskEnvironment > > This is necessary because we want content::TestBrowserThreadBundle to > own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment > and you can't have two SequenceManagers on the same thread. > > This patch allows ScopedTaskEnvironment to optionally work with an > externally owned SequenceManager solving the problem. > > This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, > > We now have the ability to mock time on the UI thread. > > TBR=asvitkine@chromium.org,miu@chromium.org > > Bug: 863341, 891670, 708584 > Change-Id: I96aa34c5cc8832c263621c2d9c228a8da4372c68 > Reviewed-on: https://chromium-review.googlesource.com/c/1324391 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611895} TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org Change-Id: I4b4922b5f393bcb9aace5f28b09a61fbdf2bfa04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863341, 891670, 708584 Reviewed-on: https://chromium-review.googlesource.com/c/1354723 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612026}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .