commit | d29660fdde91466d1a061e3fe85ea77b51951f00 | [log] [tgz] |
---|---|---|
author | Takuto Ikuta <tikuta@chromium.org> | Mon Sep 28 06:05:24 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 28 06:05:24 2020 |
tree | 099af246dde47ae81f7c9f7c4d18a8d86921d845 | |
parent | a4277107166dd004f77edc6cedc5db8305509bad [diff] |
Revert "[goma] remove --is-luci flag" This reverts commit 09dbcd9e5a6d083efe55e51c07f7ef14053533bf. Reason for revert: culprit for http://b/169274108 Original change's description: > [goma] remove --is-luci flag > > This is now always True. > > This also changes the behavior of script used by goma recipe modules. > > Bug: 1128847 > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: chrome_release > Change-Id: I07f8a75f05877f70b94f612acf5b046a6c0b0529 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2413708 > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Bug: 1128847, b/169274108 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Change-Id: I4cc7bb7974edb28aeff7d7d9fe145bb2e0e06c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2425926 Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.