commit d2d10b8f9fdd389a02bed05dfb0dda57be5c4c39
author Anders Hartvoll Ruud <andruud@chromium.org> Mon Sep 17 10:39:10 2018
committer Commit Bot <commit-bot@chromium.org> Mon Sep 17 10:39:10 2018
tree a0022c070cba0236e08742a947c3536570366033
parent 0fcb0680e102b20a376ce0377f50c26b45eb6d38

[css-properties-values-api] Detect font-relative units via var() refs.

The has[_root]_font_unit flags were accidentally ignored in one of
CSSVariableData's constructors, and also not propagated properly during
variable resolution. This caused us to lose any knowledge about these units
if they appeared via an inner var() reference.

Also:

 * Fix incorrect rem test which tested the wrong thing due to the
   'compute_dimension' utility mutating its style.
 * Reduce the chance of such errors in the future by cleaning the state
   between every test, and also at the end of 'compute_dimension'.

R=chrishtr@chromium.org

Bug: 641877
Change-Id: If67cf4453e886f4c9430826c7cbe358e380c3f64
Reviewed-on: https://chromium-review.googlesource.com/1226492
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591634}