commit | d384bbe2de7b92c4959711d38499a57f6b5fdfed | [log] [tgz] |
---|---|---|
author | Dirk Pranke <dpranke@google.com> | Sat Aug 08 02:05:57 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Aug 08 02:05:57 2020 |
tree | 888c44091fbc431c030d3d860616fbc8fa54ae72 | |
parent | db4f41198381fdcc46d7608910438a0780c15e9b [diff] |
Re-revert and "Stop sending swarming command lines directly on the Chromium bots." This reverts commit ef6a47c9d777268bf0fcfabc10446ebff3056907. Reason for revert: Breaks Win7 Tests (x64)(1) for having too long of a command line passed to kitchen, apparently. https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/69773 Original change's description: > Revert "Stop sending swarming command lines directly on the Chromium bots." > > This CL reverts commits 66f7717e55066debe6cb791df01113ba065e1e4f and > e76ddd59c2e447d48d6c36bff384367e631219e8 and re-enables sending the > command lines for the builder configs that had been previously doing so. > > It effectively re-lands: > - cc5dda273c45205cf20bbc7df6174dd601a81d81 > - 81c8242381117747babfb70cbf11935a4342f9e5 > - e5e555bbda663d8268152c8870609d810bc16aa8 > - 389541ef0d2b1113b5f9a10d7998ba6f03cb7643 > > and affects the following builders: > chromium.chromeos: > - linux-chromeos-rel > - chromeos-amd64-generic-rel > - chromeos-arm-generic-rel > chromium.linux: > - Cast Linux > - fuchsia-arm64-cast > - fuchsia-x64-cast > - Linux Builder > - Linux Tests > - Fuchsia ARM64 > - Fuchsia X64 > chromium.mac: > - Mac Builder > - Mac 10.10 Tests > - Mac 10.11 Tests > - Mac 10.12 Tests > - Mac 10.13 Tests > - Mac 10.14 Tests > - Mac 10.15 Tests > chromium.gpu: > - GPU Linux Builder > - Linux Release (NVIDIA) > - GPU Mac Builder > - Mac Release (Intel) > - Mac Retina Release (AMD) > - GPU Win x64 Builder > - Win10 x64 Release (NVIDIA) > chromium.win: > - Win x64 Builder > - Win 7 Tests x64 (1) > - Win10 Tests x64 > tryserver.chromium.chromiumos: > - chromeos-amd64-generic-rel > - chromeos-arm-generic-rel > - linux-chromeos-rel > tryserver.chromium.linux: > - cast_shell_linux > - fuchsia_arm64 > - fuchsia_arm64_cast > - fuchsia_x64 > - fuchsia-x64-cast > tryserver.chromium.mac: > - mac-rel > - mac_chromium_10.10 > - mac_chromium_12.12_rel_ng > - mac_chromium_10.13_rel_ng > - mac_chromium_10.14_rel_ng > - mac_chromium_10.15_rel_ng > tryserver.chromium.win: > - win10_x64_chromium_rel_ng > > Bug: 1108005 > Change-Id: Ic8668ed6f7e7d11c3653e5575fa7c8e236171e97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2342639 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> TBR=dpranke@google.com,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com No-Tree-Checks: true No-Try: true Bug: 1108005 Change-Id: I18a300f08bd78c1864af225eb24aa005464daf16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2343991 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format
) to autoformat new code.