commit | d436a7a2e33ee105a1d85370970fde3c88255302 | [log] [tgz] |
---|---|---|
author | Brian Sheedy <bsheedy@chromium.org> | Wed Nov 21 23:21:42 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 21 23:21:42 2018 |
tree | be85ce79350bb6b44cb5e2755e1beb2d370a559d | |
parent | 334ff2830d9425d200735ac88d27f7cf9dc15658 [diff] |
Revert "Android: Factor InProductHelp UI out of Tab" This reverts commit 41ee7d38d589f07b27671455fff28041ca32aee7. Reason for revert: Cause of https://crbug.com/907602 Original change's description: > Android: Factor InProductHelp UI out of Tab > > This CL moves the methods handling InProductHelp UI in Tab to > ToolbarButtonInProductHelpController using ActivityLifecycleDispatcher and > Tab page load observing mechanism. Now the methods are handled by > ChromeTabbedActivity only. > > Bug: 889682 > Change-Id: Idce805f60f32ad90418c0f6e3ded80df6d18f9b1 > Reviewed-on: https://chromium-review.googlesource.com/c/1272779 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609881} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org,robertogden@chromium.org Change-Id: I539d82b07ee8f6a3012ad72e1f2ba35eda613d72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889682 Reviewed-on: https://chromium-review.googlesource.com/c/1347199 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610258}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .