Google Git
Sign in
chromium / chromium / src / d43f99b68cda849a6a6367548c82c205bf9ee1fd
commitd43f99b68cda849a6a6367548c82c205bf9ee1fd[log] [tgz]
authorIan Kilpatrick <ikilpatrick@chromium.org>Wed Oct 18 20:51:30 2017
committerCommit Bot <commit-bot@chromium.org>Wed Oct 18 20:51:30 2017
treee42f6a2298261ba7040394aa3f3a977566d15376
parent614899f863de3c9397495e8f210a259d6148d188 [diff]
[LayoutNG] Remove NGFragment::Offset in favour of ConvertToLogical

This was something I found yesterday, while looking at the remaining
ng-bot failures for the line-by-line patch.

We weren't calculating the NGFragment::Offset correctly (impossible
without a parent size), so I removed it in favour of:
NGPhysicalOffset::ConvertToLogical.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I88196b26d6702acf4c3b65a386eba04e2d4d1d33
Reviewed-on: https://chromium-review.googlesource.com/726299
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509866}
7 files changed
tree: e42f6a2298261ba7040394aa3f3a977566d15376
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .