commit | d47586ce757ac9d701409acb560274cef84c78ad | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Fri May 04 21:12:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri May 04 21:12:18 2018 |
tree | 1aef15398f27906e66d91f61cca1ec48389b9a65 | |
parent | afd725a7192f4340b59faeb543aaeaa2f3ba06d2 [diff] |
IWYU: Include <algorithm> in secure_display_link_tracker.h. Recent changes that removed some includes such as a92b7636e ("[MessageLoop] Fix random IWYU preventing message_loop.h cleanup") and 629ba73c96 ("[MessageLoop] Fix message_loop.h includes") have broken the build with libstdc++, as secure_display_link_tracker.h uses std::find() but relied on it being included implicitly by other headers: In file included from ../../base/memory/weak_ptr.h:77:0, from ../../content/renderer/media/stream/media_stream_video_source.h:13, from ../../content/renderer/media/stream/media_stream_video_source.cc:5: ../../content/renderer/media/stream/secure_display_link_tracker.h: In instantiation of ‘void SecureDisplayLinkTracker<T>::Add(T*, bool) [with T = content::MediaStreamVideoTrack]’: ../../content/renderer/media/stream/media_stream_video_source.cc:55:34: required from here ../../content/renderer/media/stream/secure_display_link_tracker.h:32:19: error: no matching function for call to ‘find(std::vector<content::MediaStreamVideoTrack*>::iterator, std::vector<content::MediaStreamVideoTrack*>::iterator, content::MediaStreamVideoTrack*&)’ DCHECK(std::find(insecure_links_.begin(), insecure_links_.end(), link) == ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:888:54: note: in definition of macro ‘DCHECK’ #define DCHECK(condition) EAT_STREAM_PARAMETERS << !(condition) ^~~~~~~~~ Bug: 819294 Change-Id: I1e747d7e15a7be74460012fbe5f207368744114b Reviewed-on: https://chromium-review.googlesource.com/1043749 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#556190}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .