commit | d4a46a68e27c1b41b447beba491c08694e27687b | [log] [tgz] |
---|---|---|
author | Robert Iannucci <iannucci@chromium.org> | Wed Apr 07 19:41:08 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 07 19:41:08 2021 |
tree | 805fb5939ff0963d53ed7ff44651f518d9ca236b | |
parent | 5518914faf6cb44474e88091c00df5c3b6bdb439 [diff] |
[buildbucket/py] Stop looking at global settings for bbagent opt-in/out. This will allow us to remove the builder predicates from settings.cfg safely. This also makes sure to reliably set the use_bbagent experiment even when opted-in via `exe.cmd[0] == 'luciexe'`. R=smut, yiwzhang Change-Id: I559c1f06b7e0dbaa46e9852b84d47b6d47d77636 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2811063 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: smut <smut@google.com> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#40000}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.