commit | d4c0124fd3b8e612170bac1e4a550eb0250ca3c4 | [log] [tgz] |
---|---|---|
author | Samuel Huang <huangs@chromium.org> | Thu Nov 19 03:42:14 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 19 03:42:14 2020 |
tree | 7658acc817f2dfde67890acfc05e22704a4f0fd1 | |
parent | 601295da5061326cdbb0c1b5733460d954d01814 [diff] |
[Binary Size] Fix M87 android-binary-size bot by adding compatibility code. The android-binary-size bot for M87 did not pick up the Chromium changes needed to support size config JSON files, and as a result, fails when the binary_size recipe module passes them to (old versions of) generate_commit_analysis.py and try_commit_size_checker.py. This CL fixes the above by adding compatibility code to the binary_size recipe module, so that M87 android-binary-size bot passes old arguments (MonochromePublic with --apk_name and --mapping-name) to the above scripts. Bug: 1040645, 1150128 Change-Id: Ibf46acf7691f02ab6b9118b3e2fe34b73d532718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2548020 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.