Google Git
Sign in
chromium / chromium / src / d5cb559a5882e481ed07a1e36b4de1a8a5786dc6
commitd5cb559a5882e481ed07a1e36b4de1a8a5786dc6[log] [tgz]
authorTessa Nijssen <tnijssen@google.com>Tue Aug 14 17:50:19 2018
committerCommit Bot <commit-bot@chromium.org>Tue Aug 14 17:50:19 2018
tree8d17b2bfb15af6ec52d39420293e43183ed81d3e
parente6b8c52b00a861471a42b82ec3e038329a2e2a07 [diff]
[Mac] Don't Display Text Suggestions Touch Bar without Suggestions

If there are no suggestions, the touch bar will show an empty
NSCandidateListTouchBarItem. Instead of showing that, the browser
window touch bar should appear if there are no suggestions.

TextSuggestionsTouchBarControllerTest.MakeTouchBar was modified to
test that a text suggestions touch bar is not created if there are
no suggestions.

Bug: 717553
Change-Id: I2eb3286e5a96b97bb8d7737ddf6db352698804b8
Reviewed-on: https://chromium-review.googlesource.com/1173407
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Cr-Commit-Position: refs/heads/master@{#582967}
2 files changed
tree: 8d17b2bfb15af6ec52d39420293e43183ed81d3e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .