Google Git
Sign in
chromium / chromium / src / d6e0bb934a513d5b8e3a9fb6464eb821960e44a4
commitd6e0bb934a513d5b8e3a9fb6464eb821960e44a4[log] [tgz]
authorIan Kilpatrick <ikilpatrick@chromium.org>Thu Aug 24 01:06:34 2017
committerCommit Bot <commit-bot@chromium.org>Thu Aug 24 01:06:34 2017
treeaa3ea30037b2af1395c52007f5b3b91dd6ed5c1c
parent9f87581632a7adf06a95c89cb444619ec5933c1f [diff]
[LayoutNG] Make NGLayoutResult, NGConstraintSpace immutable.

This fixes the shared exclusion space which was being passed around a
block formatting context.

Instead of sharing currently it includes the NGExclusionSpace copy
constructor. This isn't optimal, but correct at the moment. We can
speed this up by override the NGExclusionSpace copy constructor to
share a backing vector + index into that vector.

The last bit to fix up is inside NGLineBreaker to rewind over floats.

The next followup will be constifying NGConstraintSpace everywhere.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia0b17dddf5499d5c29980c0bce846e472998ad50
Reviewed-on: https://chromium-review.googlesource.com/621390
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496901}
18 files changed
tree: aa3ea30037b2af1395c52007f5b3b91dd6ed5c1c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .