commit | d6fe2acab1556fab23123e768eba7a7b0daadd48 | [log] [tgz] |
---|---|---|
author | Roger McFarlane <rogerm@chromium.org> | Fri Aug 10 14:45:59 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Aug 10 14:45:59 2018 |
tree | 752e8fe22baae2a1305a5efbf27139819661d7a7 | |
parent | e0fdc66eefb8230cc1691f8e4287857b706e1a6f [diff] |
[autofill] Support consolidated uploads for a field. This CL changes the uploaded autofilltype (i.e. vote) field to be repeating instead of a single required field per uploaded field. Background: The autofill upload proto has a repeated "Field" attribute that has a single required autofilltype field. Autofill can send multiple votes for a given field (if a field matches the users full address as well as address line 1, for example). Prior to this CL, clients would send multiple "Field" entries (repeating all attached metadata) in the event of multiple votes. Clients also send multiple "Field" entries if there are fields having the same signature (address line 1,2, sharing the same field name/id, for example, is not uncommon). The recipient of these votes is not able to tell these 2 cases apart (multiple votes for a single field vs votes for multiple fields with the same signature). With this CL, clients will upload exactly one "Field" entry per logical field in the form. In this way all type votes for a field will be consolsidated to a single Field entry. It will also consolidate (instead of repeating) any additional metadata send about the field into that single entry for the field. Bug: 850606 Change-Id: I73acea17f755b6ebe37f11c9e72e02f9bf1c5484 Reviewed-on: https://chromium-review.googlesource.com/1142485 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582158}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .