Google Git
Sign in
chromium / chromium / src / d77c5029a13a83e676833aea61966a003564e57a
commitd77c5029a13a83e676833aea61966a003564e57a[log] [tgz]
authorchaopeng <chaopeng@chromium.org>Wed Apr 10 23:50:01 2019
committerCommit Bot <commit-bot@chromium.org>Wed Apr 10 23:50:01 2019
treed7a1a550c8ce512321b0f5805166ae81d7a56db6
parent059035c6e0f15044881d30f314cbdd5e8c06ffe4 [diff]
Move Viewport reset into DirectManipulationEventHandler

The crash report shows DirectManipulation may call
DirectManipulationEventHandler OnViewportStatusChanged
to READY state after DirectManipulationHelper Destroyed
then crash because we called Reset to invalidate DMHelper.

In this CL, we pass the viewport size to DMEventHandler
and use it to reset viewport at gesture end. Also
DMEventHandler does not need to store pointer of DMHelper.

Bug: 951293
Change-Id: I39a3402659b9ae117ab45288b68dd5d595e58457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562153
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649712}
4 files changed
tree: d7a1a550c8ce512321b0f5805166ae81d7a56db6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .