commit | d9799c4893323be68d4bf1aea7cab56c60bee0dd | [log] [tgz] |
---|---|---|
author | Garrett Beaty <gbeaty@chromium.org> | Fri Oct 09 19:27:00 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 09 19:27:00 2020 |
tree | 98a3b3a1b4a61298b8fb647785c40f6cd5908350 | |
parent | e8a1be6cc0102252d1094342ebb519058febd700 [diff] |
Create a no-op step to set the target_buildername property on. Currently, the target_buildername property is being set on the step result retrieved via step.active_result, but this relies on whatever code was last executed leaving an open step, which unnecessarily constrains the implementation of the called code. Change-Id: Ia95813d5c2e0f13d31072919d609065e87bea72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2454508 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.