commit | da27378f03ea3dc4bdba82e3cb1d13ad2fef7a7c | [log] [tgz] |
---|---|---|
author | Yuki Yamada <yukiy@google.com> | Wed Sep 05 03:00:10 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 05 03:00:10 2018 |
tree | d92c23cd87a08462264ede4b8771d27e5b31f419 | |
parent | 683690300a6f2b0f8d2acff300f856065c826cd7 [diff] |
Split implementation of EventListener and EventHandler This CL add new class blink::V8EventListenerImpl which implements ONLY EventListener (not EventHandler). It has a blink::V8EventListener which inherits blink::CallbackInterfaceBase. As a result, EventListener will start to handle incumbent realm. EventHandler will still be offered by blink::V8AbstractEventListener (this class is renamed to blink::V8AbstractEventHandler in this CL) after this CL submitted. Also, entry realm was set to wrong one (event target's one) with blink::V8AbstractEventLisntener so this CL set it to listener's one as defined in standard. Regarding crbug.com/872138 : Current blink::V8AbstractEventListener implements both of EventListener and EventHandler, so I am trying to implement new class for EventListener first to separate these. EventHandler will be modified in following CLs. Regarding crbug.com/878658 : This CL modifies expectation file for layout test: fast/events/touch/gesture/gesture-tap-frame-removed.html This is because event listener starts to remember incumbent realm after this CL and it results in incorrect behavior as explained in the BUG. This is not a regression, but have to be resolved in following CLs. Bug: 872138, 878658, 606900, 849236 Change-Id: I4bf7fe2f4fd51287f873c2377edfd57e4bb2a54a Reviewed-on: https://chromium-review.googlesource.com/1172234 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#588748}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .