commit | da94bf9e3346524cbe0059e9aa6d58ac80041ff2 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@chromium.org> | Tue Jan 08 18:06:59 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 08 18:06:59 2019 |
tree | 7bd3265b1c9093b417fb6aa808a4d01f099b9768 | |
parent | 27ac4fc7a586c8a86aaae687dd15c6c57a11e76d [diff] |
Make RTCRtpContributingSource a dictionary. Before this CL it was an interface, but the spec changed this to a dictionary a long time ago. This is mostly refactoring efforts in preparation for getSynchronizationSources(), but there is one behavioral change: Because it is now a dictionary, every call to getContributingSources() will produce a new set of objects. In this comparison... r.getContributingSources()[0] == r.getContributingSources()[0] ... the objects will be value-equal, but not reference-equal. We should add more test coverage for getContributingSources() but this is currently not testable without fakes/mocks. Bug: 893158 Change-Id: If589c3fd3bea663e4b1284a16d5a0d6a5fa72231 Reviewed-on: https://chromium-review.googlesource.com/c/1398084 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#620791}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .