commit | db0240964c06bf7fdb3bf6b2645614e87fceefab | [log] [tgz] |
---|---|---|
author | Alex Clarke <alexclarke@chromium.org> | Tue Sep 25 07:43:56 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Sep 25 07:43:56 2018 |
tree | 0f4b7a10b36e3e5d301138ed286d3d4099c7b126 | |
parent | 3034e414715b68fcb5b658f5e6753d8b21909a43 [diff] |
Make Chrome_DevToolsADBThread shutdown gracefully in tests To land the BrowserUIThreadScheduler we need in tests for all threads to stop using base::PostTaskWithTraits before the scheduler is deleted. Currently this is true for the UI and IO threads but it's not true for Chrome_DevToolsADBThread. This patch makes sure references retaining AndroidDeviceManager::HandlerThread are released in tests which triggers thread shutdown, fixing the problem. Bug: 863341, 872372 Change-Id: Iec737aac74fb62118d07b6cf878a14db055f5be5 Reviewed-on: https://chromium-review.googlesource.com/1238468 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593850}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .