Google Git
Sign in
chromium / enterprise / cel / dc3bed0aa25bf261c65b4ded2eda17b9a6185a1e
commitdc3bed0aa25bf261c65b4ded2eda17b9a6185a1e[log] [tgz]
authorMathieu Binette <mbinette@google.com>Tue Dec 18 18:57:26 2018
committerMathieu Binette <mbinette@google.com>Tue Dec 18 19:00:33 2018
tree8c9455d1058897fc2f9e68d65d7f83d491cdc51c
parente47c5eb8dec18dac29156aad4a098a8dd7861038 [diff]
Fix RunCommand regression with --version

We wanted to have the version printed out in the deployment logs to be help investigate
failures from those logs, but adding it everywhere broke commands where output is parsed.

Let's just print it in cel_ctl deploy.

This would've been caught by our tests running automatically, so can't wait to have that. :)

Also made two improvements to RunPowershell:
 1. Ignore progress output - it used to pollute the output stream and can crash commands that rely on parsing the output.
 2. Remove prefix/trailing whitespace. Not a huge issue but they're common useless bytes when using '''
myscript here
'''

Change-Id: Ib6419fad7f326cad80dff48ede83d4d7c490007e
Reviewed-on: https://chromium-review.googlesource.com/c/1383071
Reviewed-by: Fei Ling <feiling@chromium.org>
3 files changed
tree: 8c9455d1058897fc2f9e68d65d7f83d491cdc51c
  1. build/
  2. docs/
  3. examples/
  4. go/
  5. infra/
  6. resources/
  7. schema/
  8. scripts/
  9. test/
  10. .gitignore
  11. .gitmodules
  12. .style.yapf
  13. build.py
  14. CODE_OF_CONDUCT.md
  15. codereview.settings
  16. CONTRIBUTING.md
  17. Gopkg.lock
  18. Gopkg.toml
  19. LICENSE
  20. navbar.md
  21. OWNERS
  22. PRESUBMIT.py
  23. README.md
  24. test.py
  25. VERSION
README.md

Chrome Enterprise Lab

Chrome Enterprise Lab is an inaccurately named set of tools for building enterprise labs quickly and easily. The labs so built can be used for system level end-to-end testing of Google Chrome/Chromium.

Have a peek at the Design document.

Also have a peek at the Code of Conduct.

Most of the code is in Go. See Guide to code to get a head start on the code in this repository.

Building

Prerequisites

  • Go: Download Go from the Go download page. This project requires Go 1.9.4 or later. The build will fail with prior versions.

  • Depot Tools: Used for managing the checkout and the contributor workflow.

  • Protocol Buffers Compiler: Protocol buffers are used extensively for wranging all the data that needs to be shuttled around. Can be installed automatically via ./build.py deps --install.

  • Dep : Used for Go depedency management. This can be installed automatically by running ./build.py deps --install from the root of the source tree.

  • Go support for Protocol Buffers : This can be installed automatically by running ./build.py deps --install from the root of the source tree.

Get The Source

There are two ways to get the source. One is to use managed deps, and the other is to use plain go get. The latter workflow doesn't quite work yet due to this repository not being integrated with go.chromium.org. So this page only mentions the managed dependency workflow.

  1. Clone this repository:

    Assumes that $GOPATH is a single path and not a : delimited list.

    mkdir -p ${GOPATH}/src/chromium.googlesource.com/enterprise
cd ${GOPATH}/src/chromium.googlesource.com/enterprise
git clone https://chromium.googlesource.com/enterprise/cel
cd cel

  2. Get the dependencies:

    python build.py deps --install

Build It

  1. Use the build script:

    python build.py build

  2. Also make sure the tests pass.

    python build.py test

Contributing

See CONTRIBUTING.