Google Git
Sign in
chromium / chromium / src / dcf55c3a64e394ffbf3921c5be62ef18638c5e70
commitdcf55c3a64e394ffbf3921c5be62ef18638c5e70[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Fri Jul 27 02:56:08 2018
committerCommit Bot <commit-bot@chromium.org>Fri Jul 27 02:56:08 2018
tree7dce7b04f8e7000ad0eb0827436fc1de824bd9a2
parent8fa347f197f1e0246d128fc15b1cc3598c326bfa [diff]
Pass the source string to ShapeResult functions

This patch changes OffsetForPosition and PositionForOffset
functions to accept its source string, and let callers to
pass them.

The given strings are not used yet in this patch, other than
DCHECK with the number of characters in the ShapeResult.

Computing grapheme cluster list for all ShapeResult turned
out to be not cheap enough for LayoutNG that this patch is
the preparation to compute them when needed.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6dc22fda781f63219fba74381da87f1f0b33e85f
Reviewed-on: https://chromium-review.googlesource.com/1118062
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578525}
8 files changed
tree: 7dce7b04f8e7000ad0eb0827436fc1de824bd9a2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .