commit | dd8514e8c3a0e491ee942b3552b32653bec08b5d | [log] [tgz] |
---|---|---|
author | Vadim Shtayura <vadimsh@chromium.org> | Thu Jan 03 23:44:31 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 03 23:44:31 2019 |
tree | 7d6275e4830d2eb252484de6bdedacfc4777ef97 | |
parent | 77f100c7004cc7f15aec4c9564cfe425fd240b50 [diff] |
[lucicfg] Initial empty definition of core.builder rule. There is an aspect that makes the implementation somewhat tricky: we want to allow to refer to builders using their names alone (without specifying the bucket name), if this is unambiguous. For cases when there are more than one builder with a given name, the ambiguity can be resolved by using the full builder name (e.g. "ci/linux builder"). This is solved by introduction of intermediate 'builder_ref' node: * Nodes that refer to builders have builder_refs as children. * A builder_ref has a builder as a child. * A single builder has two parent builder_ref's: one has bucket-scoped name (e.g. "ci/linux builder") and another is global (e.g. "linux builder"). * Ambiguities manifest as builder_ref nodes with more than one child. There's an internal API to follow such refs. R=nodir@chromium.org, tandrii@chromium.org BUG=833946 Change-Id: I1c126dd3f387a5915f4c49079b05acb1d95b45c8 Reviewed-on: https://chromium-review.googlesource.com/c/1390984 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.