commit | ddf5c06d226b5f4ff9678b5f5787491d2ac3dbb1 | [log] [tgz] |
---|---|---|
author | Robbie Iannucci <iannucci@chromium.org> | Wed Apr 07 00:21:11 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 07 00:21:11 2021 |
tree | bf3f604b29776205711125ff0a53797620322454 | |
parent | cb3a154c9918e4a20ff3514d4c988e7c0392b5a1 [diff] |
Revert "[buildbucket/py] Add luci.swarming.use_rbe_cas temporarially." This reverts commit ee103cb455c55aef0cc37cf0d7db17e608bb00df. Reason for revert: Experiment was renamed to not be 'luci.' Original change's description: > [buildbucket/py] Add luci.swarming.use_rbe_cas temporarially. > > This will allow us to roll out the new experiment support CLs today; We > can rename the experiment in parallel. > > In particular, this does NOT ensure that "luci.swarming.use_rbe_cas" > is marked as negative on builds which don't have it, since we're > planning to rename it. > > R=​smut, tikuta, vadimsh, yiwzhang, yuanjunh > > Bug: 1093970,1143122 > Change-Id: I84c3b9e3fb292ff88e084c6e258dc89600600abb > Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2807534 > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Auto-Submit: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#39946} Bug: 1093970 Bug: 1143122 Change-Id: I1b8beb029fc7d3ee74d2398bb46f6ff9dcca2a31 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2809833 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#39964}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.