commit | de2ab4adbc8b9505b35a49772e774d0395bfa812 | [log] [tgz] |
---|---|---|
author | Tiffany Zhang <zhangtiff@google.com> | Wed Apr 07 21:07:38 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 07 21:07:38 2021 |
tree | a61106fa760c1bf83b21a037f19b9a885212cbbc | |
parent | 8bbcc5342e66a358aa4d2243f4fecdeb416bb639 [diff] |
Monorail: Add React-rendered base for the issue wizard page. Prerequisite CL: https://chromium-review.googlesource.com/c/infra/infra/+/2625280 This is a proof of concept of two things: - Adding TypeScript support to Monorail. - Adding React pages to our existing Monorail SPA, in a way that doesn't increase bundle size for non-React pages, allowing us to incrementally update Monorail to React, if we desired. Demo: https://37252-7fe3987-tainted-zhangtiff-react-test-dot-monorail-dev.appspot.com/p/chromium/issues/wizard Referenced doc: https://reactjs.org/docs/web-components.html Bug: monorail:8931 Change-Id: I77eb208109d4b2755aac676355306f9c23681c43 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2602796 Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> Reviewed-by: Philip Walls <pawalls@google.com> Cr-Commit-Position: refs/heads/master@{#40003}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.