commit | de60d0c16185372421a46c78f74e8e4a5fdfea20 | [log] [tgz] |
---|---|---|
author | Alex Clarke <alexclarke@chromium.org> | Tue Sep 25 16:53:48 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Sep 25 16:53:48 2018 |
tree | 34be88924817929a83df9b60ec90fe36be626ecc | |
parent | 3b92e5f0570399d4dbcacf74da8556edb24b7a82 [diff] |
Reland "Make Chrome_DevToolsADBThread shutdown gracefully in tests" Relanding https://chromium-review.googlesource.com/c/chromium/src/+/1238468 The fix can be seen in the delta between patch set 1 and 2. Original patch description: Make Chrome_DevToolsADBThread shutdown gracefully in tests To land the BrowserUIThreadScheduler we need in tests for all threads to stop using base::PostTaskWithTraits before the scheduler is deleted. Currently this is true for the UI and IO threads but it's not true for Chrome_DevToolsADBThread. This patch makes sure references retaining AndroidDeviceManager::HandlerThread are released in tests which triggers thread shutdown, fixing the problem. TBR=dgozman@chromium.org,finnur@chromium.org,mlamouri@chromium.org Bug: 863341, 872372, 888994 Change-Id: Ie9298d652cad2df6ad93d19cfb3dd5b76fdcf339 Reviewed-on: https://chromium-review.googlesource.com/1243115 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593970}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .