Google Git
Sign in
chromium / infra / infra / deb51ebb348fb9c17d2f719a7b5160856dcaf6e0
commitdeb51ebb348fb9c17d2f719a7b5160856dcaf6e0[log] [tgz]
authorQuang Minh Tuan Nguyen <nqmtuan@google.com>Wed Apr 14 21:41:01 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 14 21:41:01 2021
treeb54a4d28dee14536fbff1d09f14e9694aa6323bb
parentcd6cbf248f1df44e0a06af0d7dcbc8121fc898d0 [diff]
[Findit] Change master to main in GetClDetails

The last time Findit was successful in creating a revert CL is on April 5: https://chromium-review.googlesource.com/c/chromium/src/+/2805257.

Looking at the log, it seems Findit failed to query for the CL details: https://screenshot.googleplex.com/5EK9Pv5h6FNM2oS. I suspect it may have something to do with the master -> main migration.



Bug: 1198825
Change-Id: I8cf0f3a066260cc711181352d8ae7b4491e2afbd
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2823198
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com>
Cr-Commit-Position: refs/heads/master@{#40168}
1 file changed
tree: b54a4d28dee14536fbff1d09f14e9694aa6323bb
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.