commit | e13f2ff40bcf2dcfa94d4424438f6d0d3b32acee | [log] [tgz] |
---|---|---|
author | littledan <littledan@chromium.org> | Thu Jan 14 19:22:46 2016 |
committer | Commit bot <commit-bot@chromium.org> | Thu Jan 14 19:23:26 2016 |
tree | 0d4ac01c7de94d449d83f760e4cf51b4d0dc7fba | |
parent | bcde4e271e300af1ca04e22f76e1edc0680d951e [diff] |
Construct instances of base class from TypedArray.prototype.subarray Previous changes with subclassable builtins and @@species were a bit aggressive in making TypedArray.prototype.subarray act like the ES2016 specification in terms of returning an instance of the subclass as a result. It turns out that Node.js, and extracted libraries for the web, subclass TypedArrays but don't expect the subclass constructor to be called by subarray. @@species will provide an escape hatch, but it has not shipped yet, and will take some time for uptake by libraries. For now, this patch makes TypedArray.prototype.subarray fall back to constructing an instance of the parent TypedArray class, such as Uint8Array. R=adamk LOG=Y BUG=v8:4665 Review URL: https://codereview.chromium.org/1583773005 Cr-Commit-Position: refs/heads/master@{#33312}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.