Google Git
Sign in
chromium / chromium / src / e19e2b8200d28523bab0364381641dff8336a528
commite19e2b8200d28523bab0364381641dff8336a528[log] [tgz]
authorDoug Turner <dougt@chromium.org>Thu Sep 07 18:16:01 2017
committerCommit Bot <commit-bot@chromium.org>Thu Sep 07 18:16:01 2017
tree1c03d2fa97d1602386e34e9c0f7372d498083eaa
parent0d0c142a92ce08a4a205aeaa8e218e30915b6ab7 [diff]
Correct comment in BACW.

Essentially, these methods can not be removed completely until the referenced
interface is also migrated over to AXPlatformNodeWin.  The reason is that they
have a name conflict which causes the compiler to get confused about the hidden
overloaded virtual function.  For example:

../..\content/browser/accessibility/browser_accessibility_com_win.h(283,3):

error: 'content::BrowserAccessibilityComWin::get_attributes' hides overloaded
virtual function [-Werror,-Woverloaded-virtual]

  get_attributes(unsigned short max_attribs,
  ^

../..\ui/accessibility/platform/ax_platform_node_win.h(377,16):  note: hidden
overloaded virtual function 'ui::AXPlatformNodeWin::get_attributes' declared
here: different number of parameters (1 vs 5)

STDMETHODIMP get_attributes(BSTR* attributes) override;

Bug: 703369
Change-Id: Ie60e432c5630b0a6c268683f6b38d80e42faa349
Reviewed-on: https://chromium-review.googlesource.com/653190
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500335}
2 files changed
tree: 1c03d2fa97d1602386e34e9c0f7372d498083eaa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .