commit | e2acbabcf55c13d6b97930d2f69ff7471893e732 | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Fri Sep 21 09:45:32 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Sep 21 09:45:32 2018 |
tree | 34c05ad9c7b26e54b507478856eafcf95f082615 | |
parent | 8006ba4895a93f2385c9a35a0d10228b6fd06750 [diff] |
[css-properties-values-api] Remove root-inherited variables properly. Currently, StyleInheritedVariables::RemoveVariable removes variable data properly (i.e. it sets the value to nullptr locally), but only nullifies the registered value if we already have an entry for that variable locally. This means that if we inherit a variable via the root bucket, calling ::RemoveVariable will not actually remove the variable. Fix by setting registered value to nullptr if a non-nullptr value would have been returned from the root. R=futhark@chromium.org Bug: 641877 Change-Id: I78f0442bd0a8eba26e74a8a152b5bee048fbc23c Reviewed-on: https://chromium-review.googlesource.com/1235724 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593135}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .