commit | e2de0f9a45dc3e898f5c784f1054667d662c5e10 | [log] [tgz] |
---|---|---|
author | Hiroshige Hayashizaki <hiroshige@chromium.org> | Wed Nov 14 02:14:16 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 14 02:14:16 2018 |
tree | e9b033681ce1650c490bca63251535118209de13 | |
parent | 161961235715f25c10ba1148de76a4d0ef1310c4 [diff] |
Implement FetchClientSettingsObject::GetHttpsState() Previously, FetchClientSettingsObjectImpl - Is used as WorkerFetchContext's FetchClientSettingsObject, - Implements GetHttpsState(), and - Is used for checking mixed contents on workers. Issue 880027 will introduce outsideSettings WorkerFetchContext which will have FetchClientSettingsObjectSnapshot as its FetchClientSettingsObject [1]. Therefore, this CL switches - WorkerFetchContext's FetchClientSettingsObject and - MixedContentChecker::IsMixedContent() to use FetchClientSettingsObject (not ...Impl), and implements GetHttpsState() in FetchClientSettingsObject and FetchClientSettingsObjectSnapshot. This CL shouldn't change the behavior at this time, because WorkerFetchContext's FetchClientSettingsObject is still a FetchClientSettingsObjectImpl object, and thus mixed content checks is done using already-implemented FetchClientSettingsObjectImpl::GetHttpsState(). The code path added in this CL will be used in [2]. [1] https://chromium-review.googlesource.com/1328043 [2] https://chromium-review.googlesource.com/1328164 Bug: 880027 Change-Id: I399694bd239c21fe9b5a650fcb689fb2c98572f5 Reviewed-on: https://chromium-review.googlesource.com/c/1328162 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#607860}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .