commit | e303cffd9dd382b53c5d9017c78b7816f38a870c | [log] [tgz] |
---|---|---|
author | Xi Han <hanxi@chromium.org> | Thu Sep 06 14:15:41 2018 |
committer | Xi Han <hanxi@chromium.org> | Thu Sep 06 14:15:41 2018 |
tree | 8a8d70f960a46b3cf2d7382f17ba760069371948 | |
parent | 8edcdc05a13b4fce25789ec82cf381203bf0bea0 [diff] |
Revert "[FeatureList] Change GetApplicationLocale() in VariationsServiceClient to be a local function. [2/3]" This reverts commit 08ae48ad56797b61f478f92dc243fc2dc09cccd3. Reason for revert: crbug.com/879703, crbug.com/879547. Original change's description: > [FeatureList] Change GetApplicationLocale() in VariationsServiceClient to be a local function. [2/3] > > Before this function uses a pref in Chrome so we need to override it in Chrome > to access that pref value. > > As a followup for this cl https://crrev.com/c/1135198, > now we can access the pref directly in componment/ and we no longer need to do that. > > This CL comes from https://crrev.com/c/1140356. See previous discussion there. > > Bug:729596 > TBR=asvitkine@chromium.org > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I7bf5631b81436344ccb17aaa2a8d6ac4167f5d7f > Reviewed-on: https://chromium-review.googlesource.com/1147481 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586711} TBR=sky@chromium.org,jam@chromium.org,asvitkine@chromium.org,hanxi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 729596,879703, Change-Id: I9447c4a44c5f77b6d6cbe633110895c6940d9fad Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1203881 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588564}(cherry picked from commit bbd73f075981027f4c8a4922b97d87b6a17c7f86) Reviewed-on: https://chromium-review.googlesource.com/1209548 Cr-Commit-Position: refs/branch-heads/3538@{#88} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .