commit | e3bd126257e4f85efbbdf9b6f36a0fece04bde3d | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Wed Feb 13 21:54:16 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 13 21:54:16 2019 |
tree | 0bab90477db06937ffe7edf69531f8eeeb294543 | |
parent | 07fa3dd71b0e62bd4a25872aa9c5fec68e820d72 [diff] |
Remove blink::CompositorAnimationHost. (2/n) We want to remove WebLayerTreeView and to do so we must remove the CompositorAnimationHost() method from it. While doing so, instead of adding a replacement method in WebWidgetClient, pass the AnimationHost directly to the WebWidget::SetLayerTreeView(). This avoids an A->B->A re-entrancy since SetLayerTreeView() would ask back for the AnimationHost anyway. While passing in a cc::AnimationHost to SetLayerTreeView(), drop the blink wrapper type and use cc::AnimationHost directly everywhere. This is mostly mechanical except: - Make WebViewImpl always expect there to be an animation host, instead of storing a null when IsThreadedAnimationEnabled() is off. - Then have ChromeClientImpl check for the feature explicitly instead of handling nullptrs. - Rearrange some code in tests that was causing us to have a null AnimationHost when we truly didn't expect to! This exposed some weird ordering stuff but it is resolvable in the test harness. R=haraken@chromium.org Bug: 912193 Change-Id: Ide492ea5cf809f3be2bddf727db728d1d7e9f3d6 Reviewed-on: https://chromium-review.googlesource.com/c/1461503 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#631899}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .