commit | e3e1bc737140de3f68b2a40dfa1f51ad3815460c | [log] [tgz] |
---|---|---|
author | erikchen <erikchen@chromium.org> | Thu Jan 18 16:31:29 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 18 16:31:29 2018 |
tree | ac4f9511d718893dece0c38b6a9378eb2084f78f | |
parent | 692248a91318264677b99a68667fab3a2e8afa31 [diff] |
Fix memory leak in Linux libsecret wrapper. secret_service_search_sync returns a glist, whose elements must also be freed. The existing code did not do this. This CL creates a new SearchHelper to wrap this call. The results are stored in the SearchHelper, whose destructor will correctly free the elements. This CL updates the key_storage_libsecret and native_backend_libsecret unittests to return real GObjects from secret_service_search. The tear down steps now check that the GObjects are correctly unreffed by the caller. Bug: 801702, 393395 Change-Id: I0dcac794d4d79499742aea6e7e42a99135367a51 Reviewed-on: https://chromium-review.googlesource.com/871930 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#530162}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .