Google Git
Sign in
chromium / chromium / tools / build / e4008a0129546e0d3627cc4ae23bdc02ead754f0
commite4008a0129546e0d3627cc4ae23bdc02ead754f0[log] [tgz]
authorLiviu Rau <liviurau@chromium.org>Fri Apr 09 09:18:09 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 09 09:18:09 2021
tree1f9bdf795b3c96d6088fbe2307ad015f80442954
parenta3a8697248bb0df89fa57b519797103cd4f43c07 [diff]
[devtools] Fall back on commit id when revision prop is missing

Led test:
https://luci-milo.appspot.com/raw/build/logs.chromium.org/devtools-frontend/led/liviurau_google.com/bf00c4316f5fe4c889a21fb7fd05365398f4ee70901be8f277cddd01ed146669/+/build.proto

Bug: chromium:1197406
Change-Id: Ic72b62629688674e254f7c33ab599a58007324e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2814617
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
6 files changed
tree: 1f9bdf795b3c96d6088fbe2307ad015f80442954
  1. infra/
  2. recipes/
  3. scripts/
  4. site_config/
  5. .gitattributes
  6. .gitignore
  7. .style.yapf
  8. .vpython
  9. .yapfignore
  10. codereview.settings
  11. CROS_OWNERS
  12. DEPS
  13. environment.cfg.py
  14. LICENSE
  15. OWNERS
  16. PRESUBMIT.py
  17. README.md
  18. WATCHLISTS
README.md

Recipes

If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.