commit | e4404c2f93e2d2ccacf15b07c834bff8051ddb63 | [log] [tgz] |
---|---|---|
author | Hiroki Nakagawa <nhiroki@chromium.org> | Thu Oct 05 07:08:46 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Oct 05 07:08:46 2017 |
tree | ad5f483ea7617cbe9feaa0ee5c53e54734d278ee | |
parent | 91cd26551327a00234dbe51bce1acddca6d1fd75 [diff] |
ServiceWorker: Move InstalledScriptsManager access from WorkerThread to SWGlobalScope For cleanup, this CL moves InstalledScriptsManager access from WorkerThread::InitializeOnWorkerThread() to ServiceWorkerGlobalScope::EvaluateClassicScript() because only ServiceWorker needs to access the manager and placing it in EvaluateClassicScript() looks more natural like importScripts(). <Motivation> My final goal is to remove script evaluation code from WorkerThread and leave it up to each owner of WorkerThread so that WorkerThead is no longer concerned with how to evaluate scripts (i.e., "classic", "module", lazy eval for worklets). For example, for DedicatedWorker, DedicatedWorkerMessagingProxy may post a task to call WorkerGlobalScope::EvaluateClassicScript() or WorkerGlobalScope::ImportModuleScript() (to be added later) based on "WorkerType"[1] after initializing DedicatedWorkerThread. [1] https://html.spec.whatwg.org/multipage/workers.html#workertype Bug: 680046, 753350, 755054 Change-Id: I546cbda16f09da66c3f94c319e498055e1f9d05b Reviewed-on: https://chromium-review.googlesource.com/701854 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506670}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .