Google Git
Sign in
chromium / chromium / src / e4ef7a62741de0e8a2df674ae2711bf87e15a921
commite4ef7a62741de0e8a2df674ae2711bf87e15a921[log] [tgz]
authorIstiaque Ahmed <lazyboy@chromium.org>Tue Aug 08 03:27:08 2017
committerCommit Bot <commit-bot@chromium.org>Tue Aug 08 03:27:08 2017
tree3a30db521b28b9f137c08ac3b94584bd53494f4c
parent9652ffa58183a00262d59b87d88d1eda8226c26b [diff]
[TaskScheduler] Migrate rest of page_capture_api.cc

Put ShareableFileReference's storage::ScopedFile on correct task runner
from FILE thread. FILE thread is deprecated. The correct task runner
here requires blocking IO and also requires TaskShutdownBehavior to
BLOCKING_SHUTDOWN.

BLOCKING_SHUTDOWN is necessary because ShareableFileReference
creates a storage::ScopedFile object inside it whose responsibility is
to delete file through
~storage::ScopedFile -> storage::ScopedFile::Reset ->
  (PostTask) base::DeleteFile.

BLOCKING_SHUTDOWN will ensure that DeleteFile is always called
when necessary.

Bug: 689520
Change-Id: Ib1943fb20fbd014b8ecfd32877323d88e0fe6761
Reviewed-on: https://chromium-review.googlesource.com/604932
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492519}
2 files changed
tree: 3a30db521b28b9f137c08ac3b94584bd53494f4c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .