commit | e5a6dfada32caaccc93e4f3ca4cb0bd0f6cdd019 | [log] [tgz] |
---|---|---|
author | Chris Palmer <palmer@chromium.org> | Tue Mar 06 21:40:08 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 06 21:40:08 2018 |
tree | f33ef36e22a4d030a3095d917d685b7849350ce8 | |
parent | 46ea76fff211538020a5a95dfcff9a8a24e51465 [diff] |
Reland "Add range checks for `StringPiece`." This reverts commit 2b0c7b406613114aa86bbe9040756e99fd913518. Reason for revert: https://chromium-review.googlesource.com/950466 re-fixed the crashpad bug, so we should be good to land this again. Original change's description: > Revert "Add range checks for `StringPiece`." > > This reverts commit c8bccdf109b1dcad454f4e26e868dc3d3af099f0. > > Reason for revert: This change has r540894 as dependency. However, r540894 was reverted in r541006, just before this patch landed. Since this currently causes failures on Mac due to crashpad errors, I am reverting this change for now. > > Original change's description: > > Add range checks for `StringPiece`. > > > > Range check `operator[]`, `front`, `back`, and `remove_{pre,suf}fix`. > > > > Bug: 817982,818376,818844 > > Change-Id: I3a0b560af273c9b04237a18a1bc0b56283d3d824 > > Reviewed-on: https://chromium-review.googlesource.com/945049 > > Commit-Queue: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Mark Mentovai <mark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#541012} > > TBR=palmer@chromium.org,dcheng@chromium.org,mark@chromium.org > > Change-Id: I7d5c2ca050869aff8dca4ba6b724761172aa1d83 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 817982, 818376, 818844 > Reviewed-on: https://chromium-review.googlesource.com/950822 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541060} TBR=palmer@chromium.org,dcheng@chromium.org,mark@chromium.org,jdoerrie@chromium.org Change-Id: I50637027781401fc96b75bb749c5baa80dcc14a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817982, 818376, 818844 Reviewed-on: https://chromium-review.googlesource.com/951868 Reviewed-by: Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#541201}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .