commit | e609dbf1db989cbd275cd2d5512221e4f0a963c6 | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Mon Oct 29 13:38:37 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 29 13:38:37 2018 |
tree | de33a44341c7523e4c70dd5ef7833016350b4ba5 | |
parent | 63959b9a07c681ddbc1c6b474b12c347a68c2aa4 [diff] |
SnapSelectionStrategy: Include <memory> IWYU. std::unique_ptr needs <memory>, which was being included indirectly and breaking the libstdc++ build after commit e806ef73a7 ("Snap after pressing arrow key"): In file included from ../../cc/input/snap_selection_strategy.cc:5:0: ../../cc/input/snap_selection_strategy.h:20:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForEndPosition( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.h:24:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForDirection( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.h:27:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForEndAndDirection( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:9:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:18:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:24:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ Bug: 819294 Change-Id: I83c594b1ae71a34f21e77c7c9d866e47629c7a61 Reviewed-on: https://chromium-review.googlesource.com/c/1304418 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#603480}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .