commit | e6d97dc362dd4a412fc7b07da0c4df53f2940a80 | [log] [tgz] |
---|---|---|
author | Robert Iannucci <iannucci@chromium.org> | Tue Apr 13 01:19:18 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 13 01:19:18 2021 |
tree | f91c23e30ea420e0ecc2908dc583d24437cf10e3 | |
parent | 5f30db6a8e0999f322377200f1624c99803ad76e [diff] |
[buildbucket/py] Stop indexing -luci.non_production. The search implementation (which is the only consumer of this field) already applies -luci.non_production in 'post' after the datastore query, so there's no reason to record this value on 99% of the builds in buildbucket. R=smut, yiwzhang Bug: 1093970 Change-Id: I08fb471689e8f45d87977968d4a8ff9e96c0c1b6 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2822124 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Cr-Commit-Position: refs/heads/master@{#40101}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.