Revert of Paint solid color backgrounds which are equivalent to locally attached into scrolling contents layer (patchset #9 id:160001 of https://codereview.chromium.org/2264663002/ )
Reason for revert:
This CL breaks paint/selection/selection-within-composited-scroller.html on WebKit Win7 (dbg).
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)
01:07:46.923 1952 worker/0 paint/selection/selection-within-composited-scroller.html crashed, (stderr lines):
01:07:46.923 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=0 y=1170 47ffffff vs ffd3d3d3
01:07:46.923 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=1 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=2 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=3 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=4 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=5 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=6 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=7 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=8 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=9 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952 [2516:5320:0902/010745:4409539:ERROR:paintcontroller.cpp(621)] "" under-invalidation: display item changed
01:07:46.924 1952 [2516:5320:0902/010745:4409555:ERROR:paintcontroller.cpp(623)] New display item: "{client: \"35B71898 Scrolling Contents Layer\", type: \"DrawingBoxDecorationBackground\", rect: [0.000000,0.000000 200.000000x1620.000000]}"
01:07:46.924 1952 [2516:5320:0902/010745:4409555:ERROR:paintcontroller.cpp(624)] Old display item: "{client: \"35B71898 Scrolling Contents Layer\", type: \"DrawingBoxDecorationBackground\", rect: [0.000000,0.000000 200.000000x1620.000000]}"
01:07:46.924 1952 [2516:5320:0902/010745:4409555:ERROR:paintcontroller.cpp(628)] See http://crbug.com/619103.
...
01:07:46.924 1952 [2516:5320:0902/010745:4409555:FATAL:paintcontroller.cpp(674)] Check failed: false.
01:07:46.924 1952 Backtrace:
01:07:46.924 1952 base::debug::StackTrace::StackTrace [0x01F0ADC7+23]
01:07:46.924 1952 logging::LogMessage::~LogMessage [0x01F5844B+59]
01:07:46.925 1952 blink::PaintController::checkUnderInvalidation [0x0AE6ACB7+839]
01:07:46.925 1952 blink::PaintController::processNewItem [0x0AE6F1D6+1558]
01:07:46.925 1952 blink::PaintController::createAndAppend<blink::DrawingDisplayItem,blink::DisplayItemClient const &,enum blink::DisplayItem::Type const &,WTF::PassRefPtr<SkPicture>,bool &> [0x0AE566C2+114]
01:07:46.925 1952 blink::DrawingRecorder::~DrawingRecorder [0x0AE56B2E+302]
01:07:46.925 1952 blink::BoxPainter::paintBoxDecorationBackgroundWithRect [0x1578E899+1001]
01:07:46.925 1952 blink::BoxPainter::paintBoxDecorationBackground [0x1578E49E+334]
01:07:46.925 1952 blink::LayoutBox::paintBoxDecorationBackground [0x15927EC4+36]
01:07:46.925 1952 blink::BlockPainter::paintObject [0x1577E854+116]
01:07:46.925 1952 blink::LayoutBlock::paintObject [0x158F27D4+36]
01:07:46.925 1952 blink::BlockPainter::paint [0x1577E329+233]
01:07:46.925 1952 blink::LayoutBlock::paint [0x158F2774+36]
01:07:46.925 1952 blink::PaintLayerPainter::paintFragmentWithPhase [0x157D17A2+658]
01:07:46.925 1952 blink::PaintLayerPainter::paintBackgroundForFragments [0x157D09B2+130]
01:07:46.925 1952 blink::PaintLayerPainter::paintLayerContents [0x157D2550+2976]
01:07:46.925 1952 blink::CompositedLayerMapping::doPaintTask [0x15A04F13+579]
01:07:46.925 1952 blink::CompositedLayerMapping::paintContents [0x15A06224+996]
01:07:46.925 1952 blink::GraphicsLayer::paintWithoutCommit [0x0ACDD0F3+499]
01:07:46.925 1952 blink::GraphicsLayer::paint [0x0ACDCC3C+44]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F746+38]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952 blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952 blink::FrameView::synchronizedPaint [0x1552F689+601]
01:07:46.925 1952 blink::FrameView::updateLifecyclePhasesInternal [0x15530B8A+1306]
01:07:46.925 1952 blink::FrameView::updateAllLifecyclePhases [0x155301D6+38]
01:07:46.925 1952 blink::Internals::layerTreeAsText [0x00534AA2+146]
01:07:46.926 1952 blink::Iterable<unsigned int,int>::keysForBinding [0x00568FE6+1814]
01:07:46.926 1952 blink::Iterable<unsigned int,int>::keysForBinding [0x0056904C+1916]
01:07:46.926 1952 v8::internal::FunctionCallbackArguments::Call [0x093DFE93+179]
01:07:46.926 1952 v8::internal::Isolate::typed_array_prototype [0x09475B48+1800]
01:07:46.926 1952 v8::internal::Builtin_HandleApiCallAsFunction [0x09476828+552]
01:07:46.926 1952 v8::internal::Builtin_HandleApiCall [0x09476505+165]
Original issue's description:
> Paint solid color backgrounds which are equivalent to locally attached into scrolling contents layer
>
> If we have a solid color background whose bounds / visible rect is equivalent to the padding-box we can treat it as locally attached and paint it into the scrolling contents layer. This enables composited scrolling with sub-pixel text anti-aliasing.
>
> BUG=381840
> TEST=CompositedLayerMappingTest.ShouldPaintBackgroundOntoScrollingContentsLayer
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/3a79cf9764213b54bf9e5a0be2198f029a3540c8
> Cr-Commit-Position: refs/heads/master@{#415973}
TBR=chrishtr@chromium.org,flackr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=381840
Review-Url: https://codereview.chromium.org/2308503002
Cr-Commit-Position: refs/heads/master@{#416226}
32 files changed
