| commit | e8bf7e7ffd98e2cd5660291ea5b7505f1a0650d1 | [log] [tgz] |
|---|---|---|
| author | alancutter <alancutter@chromium.org> | Thu Oct 27 04:21:58 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Oct 27 04:25:06 2016 |
| tree | 6423434ddce9cae734289646c27d2146434e2fd0 | |
| parent | 498b24642cfb7c8dd84ca60c65c684dbf3f60bbf [diff] |
Revert of "Added common layout framework for system menu rows." (patchset #4 id:60001 of https://codereview.chromium.org/2439093002/ ) Reason for revert: TriViewTest.ViewsRemovedOnRemoveAllChildren is leaking on Linux Chromium OS ASan LSan Tests (1) https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/17234 Original issue's description: > Reland of "Added common layout framework for system menu rows." > > Added common layout framework for system menu rows. > > Currently most of the system menu rows define their own layouts even > though many rows should have the same layout. Additionally we have to > support two separate layout schemes while material design is being > implemented. Thus this CL lays the ground work to make it easier to > support multiple layout schemes and a centralized layout source. > > Follow-up TODO: > - wire in the new layouts to the system menu rows > > BUG=657669 > > Originally landed here: https://chromiumcodereview.appspot.com/2414103003/ > Reverted here: https://codereview.chromium.org/2441923004/ > > Committed: https://crrev.com/44fcf74b6ff76829c51a504693629c6278558bab > Cr-Commit-Position: refs/heads/master@{#427851} TBR=sky@chromium.org,tdanderson@chromium.org,bruthig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657669 Review-Url: https://codereview.chromium.org/2460443002 Cr-Commit-Position: refs/heads/master@{#427936}