Google Git
Sign in
chromium / infra / infra / e8efdd433e295ad6081d2891a52d70d6ac68a484
commite8efdd433e295ad6081d2891a52d70d6ac68a484[log] [tgz]
authorQuinten Yearsley <qyearsley@chromium.org>Thu Dec 03 21:52:30 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Dec 03 21:52:30 2020
tree3743b951b2fa395c5eeb66f227d383c45e59bf4f
parent0e857fe72e1ad092eab16347b7e593bc8c8f63ad [diff]
tricium: Skip polling chromium-m* projects

Tricium assumes that different LUCI projects should have different
repos configured. This is not the case for the chromium milestone
projects, which all have different old versions of the same chromium
config.

When polling is done, Tricium effectively has been randomly taking
one of the older configs (race condition), leading to confusion
because the newer config changes sometimes don't take effect.

This is a simple hard-coded one-off fix for this issue, because:

 - Tricium will be deprecated as we're planning to merge with CV
 - The special milestone project setup is currently unique to
   chromium as far as I know

Bug: 1133552, 1154514
Change-Id: I48e4320c37ded9ff5a15cb50fe3d96ef11d6c33d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2572757
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#36880}
2 files changed
tree: 3743b951b2fa395c5eeb66f227d383c45e59bf4f
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.