Google Git
Sign in
chromium / chromium / src / e9f1978151f538cfa51fa3142e9e47c4bed855f9
commite9f1978151f538cfa51fa3142e9e47c4bed855f9[log] [tgz]
authorNasko Oskov <nasko@chromium.org>Fri Jan 04 18:32:35 2019
committerCommit Bot <commit-bot@chromium.org>Fri Jan 04 18:32:35 2019
tree616b082273837fb7809fad06d1828828e5c46c39
parent17d367e5edbfea1b30a6188ead92719d84bb1643 [diff]
Fix PopupBlockerBrowserTest tests for initiator origins.

As of https://crrev.com/617708 the expectation is that all renderer
initiated navigations must specify the origin of the document that
started the navigation.

This CL fixes PopupBlockerBrowserTest to pass when DCHECK for initiator
origin on renderer-initiated navigations is enabled. It also changes
the parameter type for CanCreateWindow from GURL to url::Origin.

Bug: 882053
Change-Id: Id75c955885bc3c3c4c0e8e5c874ae9a24bcbc8ee
Reviewed-on: https://chromium-review.googlesource.com/c/1395066
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620004}
14 files changed
tree: 616b082273837fb7809fad06d1828828e5c46c39
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .