commit | ea40334f4f03f793d6f43debe97da3ede55d52fa | [log] [tgz] |
---|---|---|
author | Stephen McGruer <smcgruer@chromium.org> | Wed Aug 12 15:29:49 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 12 15:29:49 2020 |
tree | 2636d4db9a0536775d3d064c5559d186a69ad1d3 | |
parent | 4cad51702667cfddc722f647fc41116bfa3c2400 [diff] |
Revert "Remove uses of the factory_properties from archive_build." This reverts commit ca3bbfe21c570fa919a901bfce576eab1f5fd61c. Reason for revert: suspected of breaking all *-archive-* bots; see https://crbug.com/1115522 Original change's description: > Remove uses of the factory_properties from archive_build. > > Factories were an aspect of buildbot and aren't present in LUCI. > > archive_build has had individual flags added for the properties that it > would extract from the factory properties. Unlike the other scripts with > the --factory-properties flag, the build properties were not being > passed as the factory properties. Instead, the chromium module was > actually constructing a factory properties dict from known values. This > dict never included the dual_upload property and the gclient_env > property that it was setting wasn't being read anywhere. > > Bug: 1008256 > Change-Id: I2294d817cfc0212a8bbd3b4e6f8aab85533c0842 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2350320 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> TBR=martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idf74451192b201740738f2fe436642442c80a96a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1008256, 1115522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2352529 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format
) to autoformat new code.