commit | ea50265aefdf0a262fdf315c2f4193345f6cefca | [log] [tgz] |
---|---|---|
author | Stephen Martinis <martiniss@chromium.org> | Thu May 03 22:35:00 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 03 22:35:09 2018 |
tree | 38f8ee95f755f1e92895458d87292d73d99b2b66 | |
parent | 8f20428bf4dc574b138a63ae705b74af3945cdda [diff] |
Revert "Reland "bot_update: Patch on gclient by default."" This reverts commit 8f20428bf4dc574b138a63ae705b74af3945cdda. Reason for revert: Probably broke bot update on catapult bots: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/11225 Original change's description: > Reland "bot_update: Patch on gclient by default." > > This is a reland of e38cf570fc8c0df53b576c179701efe6d683f7d2 > > The issue with win CQ bots was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1036309 > It was due to misconfigured git user.{name,email} > > Original change's description: > > bot_update: Patch on gclient by default. > > > > See [4] for the design doc for this change. > > > > We're moving the patching logic from bot_update to gclient. > > This way we can test patches of dependencies that modify their DEPS > > files as well, for example when ANGLE uploads a patch that modifies > > DEPS files to be tested by a Chromium trybot. > > > > Chromium Linux CQ and Angle trybots are already running this way > > (see [1] and [2]) and a PSA has already been sent [3] > > > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > > > Bug: 643346 > > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > > Recipe-Nontrivial-Roll: skia > > Recipe-Nontrivial-Roll: infra > > Recipe-Nontrivial-Roll: build_limited_scripts_slave > > Recipe-Nontrivial-Roll: skiabuildbot > > Recipe-Nontrivial-Roll: build > > Recipe-Nontrivial-Roll: release_scripts > > Reviewed-on: https://chromium-review.googlesource.com/1014356 > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Reviewed-by: Aaron Gable <agable@chromium.org> > > Bug: 643346 > Change-Id: I4f4edd8e815cb12a4cbc3ab690eaf588bc2accc1 > Reviewed-on: https://chromium-review.googlesource.com/1039966 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=agable@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: Ia8a5779cde3c31812121cffdd806476d4536f35e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 643346 Reviewed-on: https://chromium-review.googlesource.com/1043167 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.