commit | ee045a5ae4784d9223b1152db737f40c93a385da | [log] [tgz] |
---|---|---|
author | Johannes Henkel <johannes@chromium.org> | Sat May 12 03:45:14 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat May 12 03:45:14 2018 |
tree | 7e3721c00cc13f5a4b0f7b5dd782ab5dab4133b2 | |
parent | 931cb0298862705f5234cd9991a4e38c52fce20b [diff] |
ResourceRequestBlockedReason: use base::Optional instead of kNone value. This change will make it easier to finish https://chromium-review.googlesource.com/c/chromium/src/+/1035091: - The "other" blocked reason, that is, an unspecified blocked reason, is now the default which we'll assume for the 0 value. - There's a 1:1 correspondence with the enum in browser_protocol.pdl, so we no longer need to conflate kNone and kOther. - The base::nullopt value for base::Optional<...> is more appropriate because in the inspector's protocol it will correspond to the absence of a string value (e.g. in a JSON message), as opposed to the string "none" or "other" (both misleading). Would like to land this first since it's easier to review / test it this way, as opposed to mixing it into a larger PR. Bug: 838291 Change-Id: I66da523495b38a297d22289ae7c32367a66bd6bb Reviewed-on: https://chromium-review.googlesource.com/1056030 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558109}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .