commit | ee2ad13b341f342b83e71d4cbe27bb051a66cee9 | [log] [tgz] |
---|---|---|
author | mathp <mathp@chromium.org> | Wed Oct 21 03:16:58 2015 |
committer | Commit bot <commit-bot@chromium.org> | Wed Oct 21 03:17:46 2015 |
tree | 5f4fc3a94849c7ae61bd74ad0c25c50d3511d5bf | |
parent | b3e0e92c7c98c77503137ce6308f3904a3650edf [diff] |
Revert of Cleanup chrome/version.h handling (patchset #7 id:120001 of https://codereview.chromium.org/1405633002/ ) Reason for revert: Appears to be breaking at least Mac GN build Example failure: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/23114 Original issue's description: > Cleanup chrome/common/chrome_version.h handling > > Rename "version.h" to "chrome/common/chrome_version.h" > Update #include and GYP/GN references > Generate on all platforms > Remove redundant generated chrome/common/chrome_version.cc.version > Fix DEPS include_rules > > BUG=542807 > > Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94 > Cr-Commit-Position: refs/heads/master@{#355196} TBR=brettw@chromium.org,mdempsky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542807 Review URL: https://codereview.chromium.org/1411173003 Cr-Commit-Position: refs/heads/master@{#355231}