Google Git
Sign in
chromium / chromium / src / ee6a9e4d12a31d5f461476070dc6746efe27dbe7
commitee6a9e4d12a31d5f461476070dc6746efe27dbe7[log] [tgz]
authorTom Anderson <thomasanderson@chromium.org>Mon May 21 19:40:08 2018
committerCommit Bot <commit-bot@chromium.org>Mon May 21 19:40:08 2018
treeb10d96e7fc69448ac5b0dfb75e277d2d6cd13444
parent2084fb4f19ee5d52cfa4447b40fb9ef5763f2f23 [diff]
Confirm-to-quit: Delay quitting until accelerator is released

On Mac, they discovered long ago that quitting after holding Cmd+Q was a bad
idea since apps underneath Chrome would get the repeated Cmd+Q key event and
would also close [1].  Their solution was to delay quitting until the shortcut
is released.  To give users confirmation that Chrome is quitting, all browser
windows are faded out.

The same issue occurs on Linux and Windows (I've unintentionally closed many
background apps writing CL [2]), so this CL implements the Mac solution.

[1] http://dev.chromium.org/developers/design-documents/confirm-to-quit-experiment
[2] https://chromium.googlesource.com/chromium/src.git/+/6cbd505d3cb04e3e108e61a74f82421b66f0f655

BUG=243164
R=sky

Change-Id: Ia3de4acaf463cd5b202743d44f763c6d52fbe963
Reviewed-on: https://chromium-review.googlesource.com/1066924
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560336}
3 files changed
tree: b10d96e7fc69448ac5b0dfb75e277d2d6cd13444
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .