Google Git
Sign in
chromium / chromium / src / ee7a7bc6174f740cf9c0c58438f637ccc6c62d37
commitee7a7bc6174f740cf9c0c58438f637ccc6c62d37[log] [tgz]
authorJay Harris <harrisjay@chromium.org>Tue Oct 09 01:47:49 2018
committerCommit Bot <commit-bot@chromium.org>Tue Oct 09 01:47:49 2018
tree523bf3030542bb6861d7f852bc2fcd6fa43f3c67
parenta936b74d7db7335d0cfe10b506d79a508c21f0be [diff]
Adds a flag to open external links inside desktop PWAs

The flag `desktop-pwas-stay-in-window` controls whether
out of scope links open in an external browser. When
disabled (the default) behavior remains the same as
before this change (out of scope links open in the browser).
When enabled, out of scope links will open in the PWA
window and display the location bar (as we do already, in
bookmark apps).

This change has been made because the current flow (kicking
the user to the browser) breaks authentication flows on
some websites.

Bug: 853593
Change-Id: Id38dbd8437651133b2b5be5f05260b342066d0ce
Reviewed-on: https://chromium-review.googlesource.com/c/1242727
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597772}
8 files changed
tree: 523bf3030542bb6861d7f852bc2fcd6fa43f3c67
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .