| commit | ef389f44f3d90628cc61a294bf3e340dbccc1cd1 | [log] [tgz] |
|---|---|---|
| author | rouslan <rouslan@chromium.org> | Fri Feb 05 19:49:40 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Feb 05 19:50:55 2016 |
| tree | 394662b5c6732b4ee8f63ebbaba9afe0cbbae673 | |
| parent | 62acb0672da4163297a36dfaeb047ac740af5b83 [diff] |
Revert of [GN] Don't rewrite files with the same contents (patchset #5 id:80001 of https://codereview.chromium.org/1656253003/ ) Reason for revert: Need to revert this patch according https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues. This patch added a flaky test FilesystemUtils.WriteFileIfChanged. ----- It's a test flake: 1) Try to find the patch that caused the flake. It should be recent (e.g. last day or two) in all likelihood. 2) If successful with finding that patch, revert the patch. This is especially true if the flake is from a new test introduced in that patch. 3) Close the bug. ----- The test has failed in the following builds: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176911 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176911 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176735 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176715 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176715 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176561 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176462 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176375 ----- Example failure: [ RUN ] FilesystemUtils.WriteFileIfChanged ../../tools/gn/filesystem_utils_unittest.cc:610: Failure Expected: (last_modified) != (file_info.last_modified), actual: 2016-02-04 18:06:36.920 UTC vs 2016-02-04 18:06:36.920 UTC [ FAILED ] FilesystemUtils.WriteFileIfChanged (3 ms) [315/315] FilesystemUtils.WriteFileIfChanged (3 ms) Retrying 1 test (retry #2) [ RUN ] FilesystemUtils.WriteFileIfChanged ../../tools/gn/filesystem_utils_unittest.cc:610: Failure Expected: (last_modified) != (file_info.last_modified), actual: 2016-02-04 18:06:36.936 UTC vs 2016-02-04 18:06:36.936 UTC [ FAILED ] FilesystemUtils.WriteFileIfChanged (2 ms) [316/316] FilesystemUtils.WriteFileIfChanged (2 ms) Retrying 1 test (retry #3) [ RUN ] FilesystemUtils.WriteFileIfChanged ../../tools/gn/filesystem_utils_unittest.cc:610: Failure Expected: (last_modified) != (file_info.last_modified), actual: 2016-02-04 18:06:36.952 UTC vs 2016-02-04 18:06:36.952 UTC [ FAILED ] FilesystemUtils.WriteFileIfChanged (2 ms) [317/317] FilesystemUtils.WriteFileIfChanged (2 ms) 1 test failed: FilesystemUtils.WriteFileIfChanged (../../tools/gn/filesystem_utils_unittest.cc:579) ----- More details in http://crbug.com/584548. Original issue's description: > [GN] Don't rewrite files with the same contents > > BUG= > > Committed: https://crrev.com/f8ea5cceefcedd4a01935d5ac4d2ba71e23ac13e > Cr-Commit-Position: refs/heads/master@{#373544} TBR=brettw@chromium.org,tmoniuszko@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review URL: https://codereview.chromium.org/1672783002 Cr-Commit-Position: refs/heads/master@{#373882}