Google Git
Sign in
chromium / infra / luci / recipes-py / f069044eb4ac5e3050d42898d4f02d491d7e6c4a
commitf069044eb4ac5e3050d42898d4f02d491d7e6c4a[log] [tgz]
authorNodir Turakulov <nodir@chromium.org>Tue Mar 05 19:34:41 2019
committerCommit Bot <commit-bot@chromium.org>Tue Mar 05 19:34:41 2019
treee27b6aa89202788c888fbd88260406a09e88fd3e
parent8925d49937f06510ef00b9469e53bc69c2429da9 [diff]
Reland "[buildbucket] Use RPC protobufs"

This reverts commit 8925d49937f06510ef00b9469e53bc69c2429da9.

Reason for revert: it wasn't the cause of the breakage

Original change's description:
> Revert "[buildbucket] Use RPC protobufs"
> 
> This reverts commit 89a54e079cf02c6696ae6cac9052fa7cada7becc.
> 
> Reason for revert: Broke everything, see https://crbug.com/938555
> 
> Original change's description:
> > [buildbucket] Use RPC protobufs
> > 
> > Now that rpc.proto is available to buildbucket module, use its
> > ScheduleBulidRequest instead of passing dicts.
> > 
> > Expectation files no longer include default values because JSONPB
> > does not include them.
> > 
> > Bug: 930761
> > Change-Id: I828d5b7b1ce7a979ee111de89582c2ccc77ca526
> > Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1500393
> > Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> 
> TBR=iannucci@chromium.org,nodir@chromium.org,tandrii@chromium.org
> 
> Change-Id: I5a992372490609b60e4160dd65ce45c4a4c193bf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 930761, 938555
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1504133
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>

TBR=iannucci@chromium.org,nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org

Change-Id: I933d2e0efb335d0d145e93ecdf6bb653aa694c4d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 930761, 938555
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1504134
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
11 files changed
tree: e27b6aa89202788c888fbd88260406a09e88fd3e
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .vpython
  12. AUTHORS
  13. codereview.settings
  14. CONTRIBUTORS
  15. LICENSE
  16. OWNERS
  17. PRESUBMIT.py
  18. README.md
  19. README.recipes.md
  20. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.

Files

  • README.md

    This file!

  • doc/

    Documentation for the recipe engine (including this file!). See the design doc for more detailed design information about the recipe engine.

  • infra/

    Chrome infra config files.

  • recipes.py

    The main entry point to the recipe engine. It has many subcommands and flags; run recipes.py -h to see them. Include this in your repository to start using recipes.

  • recipes/

    Recipes in the recipe engine. These are either example recipes, or recipes which are used to test the engine (see run_test.py to see these run)

  • recipe_modules/

    Built in recipe modules. These are very useful when writing recipes; take a look in there, and look at each of their examples subfolders to get an idea how to use them in a recipe.

  • recipe_engine/

    The core functionality of the recipe engine. Noteworthy files include:

    • main.py -- The main entrypoint for the recipe engine.
    • recipes_cfg.proto -- The protobuf file which defines the format of a recipes.cfg file.
    • third_party/ -- third_party code which is vendored into the recipe engine.
    • recipe_api.py -- The api exposed to a recipe module.
    • unittests -- Unittests for the engine.

    There are also several files which correspond to a subcommand of recipes.py; run, and autoroll are some examples.

  • unittests/

    Somewhat poorly named, these are higher level integration tests.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome"
# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.