Google Git
Sign in
chromium / chromium / src / f1ebefaf786c08d353c8ee4952bcb218e515ff9a
commitf1ebefaf786c08d353c8ee4952bcb218e515ff9a[log] [tgz]
authorAiden Benner <abenner@google.com>Wed Oct 31 18:12:04 2018
committerCommit Bot <commit-bot@chromium.org>Wed Oct 31 18:12:04 2018
treeec5bdd1df9aceb526ecb99b1a0e246659c014c5b
parentaeecd28e8a3817e348ece4931f432d4934e55181 [diff]
Fix multiline-params being ignored by proxy natives

Multiline parameters in proxy natives would be ignored by the jni_generator
because the .* in the params portion of the proxy natives regex was not
matching on newlines. This CL adds the flag re.DOTALL so that dot matches
on newline which fixes the issue, and adds test coverage for this case.

Bug: 898261
Change-Id: I28f1fb3c57b39daff4d8bb1eb2bfba4a2f4d7adc
Reviewed-on: https://chromium-review.googlesource.com/c/1306694
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#604331}
2 files changed
tree: ec5bdd1df9aceb526ecb99b1a0e246659c014c5b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .